Skip to content

fix(gemini-enterprise): clean up dead variables, redundant CLI definitions, and prompt wording - #206

Merged
mgcarey-google merged 4 commits into
mainfrom
fix/gemini-enterprise-and-gem4gov-cleanups
Aug 28, 2026
Merged

fix(gemini-enterprise): clean up dead variables, redundant CLI definitions, and prompt wording#206
mgcarey-google merged 4 commits into
mainfrom
fix/gemini-enterprise-and-gem4gov-cleanups

Conversation

@aghassemlouei

Copy link
Copy Markdown
Collaborator

Description

This pull request addresses several minor non-destructive bug fixes and UX improvements in the Gemini Enterprise blueprint and gem4gov CLI:

Fixes #110
Fixes #144
Fixes #175
Fixes #176

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: N/A

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Verified CLI command groups and prompt text in gem4gov.py.
  • Verified Terraform variable definitions in gemini-stage-0 and gemini-stage-1.

@aghassemlouei aghassemlouei added bug Something isn't working gemini enterprise Gemini Enterprise (GE) related gemini for government Gemini for Government (G4G) related labels Aug 28, 2026
@aghassemlouei aghassemlouei added gemini enterprise Gemini Enterprise (GE) related gemini for government Gemini for Government (G4G) related labels Aug 28, 2026
@mgcarey-google

Copy link
Copy Markdown
Collaborator

This looks good to me. Duplicate licensing stuff confirmed, PR is clean.

@mgcarey-google mgcarey-google left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is clean. Confirmed modifications and cleanup of dead code and duplicate code.

@mgcarey-google
mgcarey-google merged commit d7d47e0 into main Aug 28, 2026
15 checks passed
@mgcarey-google
mgcarey-google deleted the fix/gemini-enterprise-and-gem4gov-cleanups branch August 28, 2026 15:49
@aghassemlouei aghassemlouei added Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment